Skip to content

#1424: Add Tables to user_migration#2292

Merged
blizzz merged 1 commit intomainfrom
feature/1424-add-table-user-migration
Feb 11, 2026
Merged

#1424: Add Tables to user_migration#2292
blizzz merged 1 commit intomainfrom
feature/1424-add-table-user-migration

Conversation

@samin-z
Copy link
Contributor

@samin-z samin-z commented Jan 30, 2026

Add ability to export/import user tables.

@samin-z samin-z changed the title #i424: Add Tables to user_migration #1424: Add Tables to user_migration Jan 30, 2026
@samin-z samin-z marked this pull request as ready for review February 5, 2026 09:36
@samin-z samin-z requested review from blizzz and enjeck as code owners February 5, 2026 09:36
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I expected to see Tables in http://nextcloud.local/index.php/settings/user/migration ? :

Image

@benjaminfrueh
Copy link
Contributor

Hmm, I expected to see Tables in http://nextcloud.local/index.php/settings/user/migration ? :

Image

@enjeck for me tables is listed there.

@samin-z
Copy link
Contributor Author

samin-z commented Feb 9, 2026

@enjeck maybe the feature table is not enabled for you and that is the reason.
@benjaminfrueh thank you for the feedbacks, I'll get to them right away.

@samin-z
Copy link
Contributor Author

samin-z commented Feb 9, 2026

@benjaminfrueh thank you for the feedback, all the applicable changes has been applied.

@blizzz
Copy link
Member

blizzz commented Feb 10, 2026

@samin-z please sign-off your commits 😇 and we can get it in

@samin-z samin-z force-pushed the feature/1424-add-table-user-migration branch 3 times, most recently from 13919c0 to 6689547 Compare February 11, 2026 10:44
move TablesMigration

update column ids for table view

use class properties instead of passing as parameters

set current user as owner

add test for TablesMigrator and fix psalm issues

php-cs fixes

check for receiver existance before insert

feedback fixes

lint and pslam fix

php-cs fix

add copyright to TableMigratorException

simplify importRow

pslam fail

Signed-off-by: samin-z <55046964+samin-z@users.noreply.github.com>
@samin-z samin-z force-pushed the feature/1424-add-table-user-migration branch from 6689547 to 3effd3c Compare February 11, 2026 11:57
@blizzz
Copy link
Member

blizzz commented Feb 11, 2026

tables-import.cy.js tests might need to be adjusted against 33 and master? But not related here.

@blizzz blizzz merged commit be1bc7d into main Feb 11, 2026
70 of 80 checks passed
@blizzz blizzz deleted the feature/1424-add-table-user-migration branch February 11, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants